[CI] add test to check libFoundation.so & co are not linked to the bi… #441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebsto
force-pushed
the
sebsto/ci_foundation
branch
2 times, most recently
from
37da1b8 to
15f6410
Compare
0xTim
reviewed
Dec 23, 2024
There was a problem hiding this comment.
GH is being really weird at the moment and diffs are broken - it's not showing this as a new file, like it's stuck diffing a particular commit or something. This file doesn't exist on main right?
There was a problem hiding this comment.
@0xTim I’m sorry I messed things up. It's not a problem with GitHub, it's me.
Now it's fixed, you should see the entire script as a new file in this PR
sebsto
force-pushed
the
sebsto/ci_foundation
branch
from
bb3f2d1 to
bc02c30
Compare
0xTim
approved these changes
Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a test in the
integration_test.ymlworkflow to verify thatlibFoundation.so,libFoundationInternationalization.so, andlib_FoundationICU.soand not linked the the function binary.This is a follow up from the work make by @t089 to ensure that we don't accidentally link Foundation again in the future.
Remove Foundation : #436
Add test in CI to ensure we don't link to foundation : #402